Review main Merged

71838[BUGFIX] Prevent PHP 8 warning in FLUIDTEMPLATE variable resolving

Alexander Stehlik CR +2 V +2 Easy +2 −1 updated 10/17/21, 14:24

Commit message

Prevent PHP 8 undefined array key warning when resolving
a FLUIDTEMPLATE variable value from a TypoScript reference:

10 = FLUIDTEMPLATE
10 {
    variables {
        myvar =< lib.some.cobject
    }
}

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Alexander Stehlik uploaded patch set 1 10/16/21, 12:28

  2. core-ci voted on patch set 1 V +1 10/16/21, 12:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18223

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/17/21, 10:46

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 10/17/21, 12:19

  5. Oliver Klee voted on patch set 1 CR +1 10/17/21, 13:49

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/17/21, 14:23

  7. Christian Kuhn merged patch set 2 10/17/21, 14:24