Review main Merged

71846[BUGFIX] Avoid php8.1 return type deprecations in LogRecord

Stefan Bürk CR +2 V +2 Easy +5 −1 updated 10/17/21, 20:16

Commit message

PHP SPL class ArrayAccess requires return values in
PHP 8.1. We can not change those since that would be
breaking in core v11. Add #[\ReturnTypeWillChange]
instead to silence PHP deprecation handler until we
raise PHP minimum version to 8.1.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Stefan Bürk uploaded patch set 1 10/17/21, 17:02

  2. core-ci voted on patch set 1 V +1 10/17/21, 17:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18253

  3. Stefan Bürk commented on patch set 1 10/17/21, 19:03

    I tried to add type hints were possible, and use the attribute where not. But I'm not sure if this "could" be breaking - because of lack of experience in that area. This would be nice if someone with experience could confirm that it is not breaking for instances.
  4. Stefan Bürk voted on patch set 1 CR -1 10/17/21, 19:07

  5. Christian Kuhn uploaded patch set 2 10/17/21, 19:43

  6. core-ci voted on patch set 2 V +1 10/17/21, 19:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18263

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 10/17/21, 20:01

  8. Simon Gilli voted on patch set 2 V +1 CR +1 10/17/21, 20:11

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/17/21, 20:16

  10. Christian Kuhn merged patch set 3 10/17/21, 20:16