71848[BUGFIX] Avoid php8.1 return type deprecation for (Lazy)ObjectStorage
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Wouter Wolters +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1317
-
Stefan Bürk uploaded patch set 1 10/17/21, 17:47
-
Stefan Bürk updated the commit message in patch set 2 10/17/21, 17:49
-
Stefan Bürk commented on patch set 2 CR -1 10/17/21, 18:01
I want here some one with more experience. I'm not sure it is really good to add the return type hints to the methods, meaning if that could be a breaking change for instances. So -1 from me for now on my own patch. -
core-ci voted on patch set 1 V -1 10/17/21, 18:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18255
-
core-ci voted on patch set 2 V -1 10/17/21, 18:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18256
-
Stefan Bürk uploaded patch set 3 10/17/21, 18:44
-
core-ci voted on patch set 3 V +1 10/17/21, 19:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18260
-
Stefan Bürk commented on patch set 3 10/17/21, 19:06
I tried to add type hints were possible, and use the attribute where not. But I'm not sure if this "could" be breaking - because of lack of experience in that area. This would be nice if someone with experience could confirm that it is not breaking for instances. -
Stefan Bürk voted on patch set 3 CR -1 10/17/21, 19:07
-
Stefan Bürk uploaded patch set 4 10/17/21, 20:04
-
core-ci voted on patch set 4 V +1 10/17/21, 20:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18266
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/17/21, 20:44
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/18/21, 08:16
-
Wouter Wolters voted on patch set 4 CR +1 10/18/21, 09:21
-
Oliver Klee voted on patch set 4 CR +1 10/18/21, 09:31
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/18/21, 11:39
-
Christian Kuhn merged patch set 5 10/18/21, 11:39