71872[TASK] Simplify error assertion in two functional tests
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1317
-
Christian Kuhn uploaded patch set 1 10/17/21, 21:36
-
Christian Kuhn uploaded patch set 2 10/17/21, 21:37
-
core-ci voted on patch set 1 V -1 10/17/21, 21:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18268
-
Christian Kuhn uploaded patch set 3 10/17/21, 21:38
-
core-ci voted on patch set 3 V +1 10/17/21, 21:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18270
-
core-ci voted on patch set 2 V +1 10/17/21, 21:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18269
-
Christian Kuhn updated the commit message in patch set 4 10/17/21, 22:02
-
core-ci voted on patch set 4 V +1 10/17/21, 22:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18271
-
Simon Gilli voted on patch set 4 V +1 CR +1 10/17/21, 22:39
-
Stefan Bürk voted on patch set 4 V +1 CR +1 10/18/21, 07:01
-
Nikita Hovratov commented on patch set 4 V -1 10/18/21, 07:01
Without the patch I have in TranslatedSiteContentTest: OK (23 tests, 128 assertions) With the patch: OK (23 tests, 151 assertions) So there are even more assertions without the property set to null. It is probably, because the Abstract class sets the default value to 0. -
Stefan Bürk wrote 10/18/21, 07:17
Removed Verified+1 by Stefan Bürk <stefan@buerk.tech> -
Stefan Bürk wrote 10/18/21, 07:17
Removed Code-Review+1 by Stefan Bürk <stefan@buerk.tech> -
Christian Kuhn commented on patch set 4 10/18/21, 11:38
Reply
yeah. i think that's fine. i assume that property was there to suppress error checking in the past, and this is (now?) obsolete, maybe we fixed some details meanwhile. i thought about dropping that sys_log error check altogether, but i'm not 100% sure, yet. maybe another patch later. -
Nikita Hovratov voted on patch set 4 V +1 CR +1 10/18/21, 11:44
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/18/21, 11:49
-
Christian Kuhn merged patch set 5 10/18/21, 11:49