Review main Abandoned

71876[BUGFIX] Fixes importing a xml in EXT:impexp

Philipp Kuhlmay CR 0 V 0 Easy +4 −1 updated 07/23/24, 12:32

Commit message

This fixes an issue, when having not enough
memory to load a xml file which should be
imported with EXT:impexp.

When having not enough memory, the variable
$dat contains only a string with

	"Line XXX: no memory"

instead of an array which causes an TYPO3
Exception when trying to unset the field
'files' inside this string.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1116

  1. Philipp Kuhlmay uploaded patch set 1 10/18/21, 16:02

  2. core-ci voted on patch set 1 V -1 10/18/21, 16:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18283

  3. Stefan Bürk uploaded patch set 2 10/18/21, 16:36

  4. Stefan Bürk wrote 10/18/21, 16:38

    Removed cc Stefan Bürk.
  5. core-ci voted on patch set 2 V -1 10/18/21, 16:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18285

  6. Stefan Bürk uploaded patch set 3 10/18/21, 16:41

  7. Stefan Bürk uploaded patch set 4 10/18/21, 16:41

  8. core-ci voted on patch set 3 V -1 10/18/21, 16:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18286

  9. core-ci voted on patch set 4 V +1 10/18/21, 16:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18287

  10. Stefan Bürk commented on patch set 4 10/18/21, 16:59

    ImportExport.php:317 Unresolved

    That does not make much sense. Unsetting it without prior isset() check should not lead to any unusual memory consumation. Reading the issue, it seems that this is a try to get rid of the error "Cannot unset string offsets" - which would imply that $this->dat is not an array here, which would be weired.
  11. Oliver Hader commented on patch set 4 10/18/21, 17:21

    ImportExport.php:314 Unresolved

    Please use `in their environments` (basically gender neutral)
  12. Philipp Kuhlmay marked it work in progress 10/19/21, 06:58

  13. Benni Mack wrote 11/29/21, 10:12

    Change destination moved from master to main
  14. Benni Mack updated the commit message in patch set 5 11/29/21, 13:34

  15. core-ci voted on patch set 5 V +1 11/29/21, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20048

  16. Georg Ringer abandoned the change 07/23/24, 12:32

    abandoned, should be solved