71876[BUGFIX] Fixes importing a xml in EXT:impexp
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1116
-
Philipp Kuhlmay uploaded patch set 1 10/18/21, 16:02
-
core-ci voted on patch set 1 V -1 10/18/21, 16:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18283
-
Stefan Bürk uploaded patch set 2 10/18/21, 16:36
-
Stefan Bürk wrote 10/18/21, 16:38
Removed cc Stefan Bürk. -
core-ci voted on patch set 2 V -1 10/18/21, 16:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18285
-
Stefan Bürk uploaded patch set 3 10/18/21, 16:41
-
Stefan Bürk uploaded patch set 4 10/18/21, 16:41
-
core-ci voted on patch set 3 V -1 10/18/21, 16:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18286
-
core-ci voted on patch set 4 V +1 10/18/21, 16:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18287
-
Stefan Bürk commented on patch set 4 10/18/21, 16:59
ImportExport.php:317UnresolvedThat does not make much sense. Unsetting it without prior isset() check should not lead to any unusual memory consumation. Reading the issue, it seems that this is a try to get rid of the error "Cannot unset string offsets" - which would imply that $this->dat is not an array here, which would be weired. -
Oliver Hader commented on patch set 4 10/18/21, 17:21
ImportExport.php:314UnresolvedPlease use `in their environments` (basically gender neutral) -
Philipp Kuhlmay marked it work in progress 10/19/21, 06:58
-
Benni Mack wrote 11/29/21, 10:12
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 5 11/29/21, 13:34
-
core-ci voted on patch set 5 V +1 11/29/21, 14:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20048
-
Georg Ringer abandoned the change 07/23/24, 12:32
abandoned, should be solved