71881[BUGFIX] Catch and log Exception in image size detection
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Guido Schmechel +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Imaging/Exception/UnsupportedFileException.phpnew+27 −0
- typo3/sysext/core/Classes/Imaging/ImageMagickFile.php+4 −4
- typo3/sysext/core/Classes/Type/File/ImageInfo.php+16 −2
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+29 −0
- typo3/sysext/core/Tests/Unit/Type/Fixture/html_file_with_pdf_ending.pdfnew+10 −0
Review log 1823
-
Alexander Stehlik uploaded patch set 1 10/19/21, 09:36
-
core-ci voted on patch set 1 V -1 10/19/21, 09:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18300
-
Alexander Stehlik uploaded patch set 2 10/19/21, 09:40
-
core-ci voted on patch set 2 V +1 10/19/21, 09:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18301
-
Christian Kuhn uploaded patch set 3 10/19/21, 13:38
-
Christian Kuhn commented on patch set 3 10/19/21, 13:40
Do you think it would work like that, too, Alexander? I changed that since catching \Exception deep within the framework is just always pita and should be avoided when possible in any way. -
core-ci voted on patch set 3 V +1 10/19/21, 13:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18314
-
Alexander Stehlik commented on patch set 3 10/19/21, 14:15
Reply
It's perfect. Thank you very much :) -
Wouter Wolters commented on patch set 3 10/19/21, 21:09
folder do not lead to -
Alexander Stehlik updated the commit message in patch set 4 10/20/21, 06:37
-
Alexander Stehlik commented on patch set 4 10/20/21, 06:38
Reply
Done -
core-ci voted on patch set 4 V +1 10/20/21, 06:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18368
-
Christian Kuhn voted on patch set 4 V +1 CR +1 10/23/21, 20:21
-
Stefan Bürk voted on patch set 4 CR +1 10/23/21, 20:40
-
Stefan Bürk voted on patch set 4 V +1 10/23/21, 20:43
-
Christian Kuhn updated the commit message in patch set 5 10/23/21, 20:58
-
Christian Kuhn commented on patch set 5 10/23/21, 20:58
unsure about 10.4 - dropping for now. -
Stefan Bürk voted on patch set 5 V +1 CR +1 10/23/21, 20:59
-
core-ci voted on patch set 5 V +1 10/23/21, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18468
-
Christian Kuhn voted on patch set 5 V +1 CR +1 10/23/21, 21:32
-
Guido Schmechel voted on patch set 5 CR +1 10/24/21, 10:04
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/26/21, 21:35
-
Christian Kuhn merged patch set 6 10/26/21, 21:36