Review main Merged

71881[BUGFIX] Catch and log Exception in image size detection

Alexander Stehlik CR +2 V +2 Normal +86 −6 updated 10/26/21, 21:36

Commit message

When the mime type of a file can not be correctly determined
by ImageMagick when detecting image sizes, fail silently and
write the underlying Exception to the error log.

This makes sure that multi file operations like copying or
moving a folder do not lead to an inconsistent index
state when the process is aborted due to an Exception.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1823

  1. Alexander Stehlik uploaded patch set 1 10/19/21, 09:36

  2. core-ci voted on patch set 1 V -1 10/19/21, 09:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18300

  3. Alexander Stehlik uploaded patch set 2 10/19/21, 09:40

  4. core-ci voted on patch set 2 V +1 10/19/21, 09:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18301

  5. Christian Kuhn uploaded patch set 3 10/19/21, 13:38

  6. Christian Kuhn commented on patch set 3 10/19/21, 13:40

    Do you think it would work like that, too, Alexander? I changed that since catching \Exception deep within the framework is just always pita and should be avoided when possible in any way.
  7. core-ci voted on patch set 3 V +1 10/19/21, 13:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18314

  8. Alexander Stehlik commented on patch set 3 10/19/21, 14:15

    Reply

    It's perfect. Thank you very much :)
  9. Wouter Wolters commented on patch set 3 10/19/21, 21:09

    folder do not lead to
  10. Alexander Stehlik updated the commit message in patch set 4 10/20/21, 06:37

  11. Alexander Stehlik commented on patch set 4 10/20/21, 06:38

    Reply

    Done
  12. core-ci voted on patch set 4 V +1 10/20/21, 06:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18368

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 10/23/21, 20:21

  14. Stefan Bürk voted on patch set 4 CR +1 10/23/21, 20:40

  15. Stefan Bürk voted on patch set 4 V +1 10/23/21, 20:43

  16. Christian Kuhn updated the commit message in patch set 5 10/23/21, 20:58

  17. Christian Kuhn commented on patch set 5 10/23/21, 20:58

    unsure about 10.4 - dropping for now.
  18. Stefan Bürk voted on patch set 5 V +1 CR +1 10/23/21, 20:59

  19. core-ci voted on patch set 5 V +1 10/23/21, 21:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18468

  20. Christian Kuhn voted on patch set 5 V +1 CR +1 10/23/21, 21:32

  21. Guido Schmechel voted on patch set 5 CR +1 10/24/21, 10:04

  22. Christian Kuhn voted on patch set 5 V +2 CR +2 10/26/21, 21:35

  23. Christian Kuhn merged patch set 6 10/26/21, 21:36