Review main Merged

71883[BUGFIX] Add PHP 8.1 compatibility in FlashMessageQueue

Christian Kuhn CR +2 V +2 Easy +5 −0 updated 10/19/21, 12:01

Commit message

Since PHP 8.1, most internal classes are updated with
tentative return types. This will be enforced with 9.0.

It means incompatible or missing return types in extending
user land classes emit E_DEPRECATED since 8.1. We can not
add the return type in many cases since that would be
breaking in v11, solution is the #[\ReturnTypeWillChange]
attribute.

This patch adds according attributes to FlashMessageQueue,
which extends \SplQueue. No longer returning $this in
enqueue() can be done in v12 as breaking patch and mixed
return type will be usable when core requires at least PHP 8.0.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/19/21, 11:07

  2. Stefan Bürk voted on patch set 1 CR +1 10/19/21, 11:28

  3. Stefan Bürk voted on patch set 1 V +1 10/19/21, 11:30

  4. core-ci voted on patch set 1 V +1 10/19/21, 11:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18304

  5. Jochen Roth voted on patch set 1 V +1 CR +1 10/19/21, 11:59

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/19/21, 12:01

  7. Christian Kuhn merged patch set 2 10/19/21, 12:01