Review main Merged

71900[TASK] Deprecation free Serializable usage in ObjectStorage

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 10/19/21, 23:50

Commit message

extbase ObjectStorage always had a serialize() and
unserialize(), even though they always just threw
exceptions. This is probably for historical reasons
where ObjectStorage implemented further SPL classes
and had to satisfy interfaces.

To still prevent instances of ObjectStorage can be
serialized or unserialized, we rename the two
methods to the magic method names and still throw
the exceptions. This avoids shenanigans in classes
that extend ObjectStorage.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1