Review main Merged

71902[BUGFIX] Remove mssql quotes in QueryHelper::parseJoin()

Stefan Bürk CR +2 V +2 Normal +111 −9 updated 10/20/21, 17:39

Commit message

Recently adding quote syntax to typoscript
definitions has been added through #94715,
which fails in nightly on mssql.

Quotes has been removed from the join part of
a query build in TypoScript content objects,
to let dbal handle the dbms quoting.
QueryHelper::parseJoin() has done this only
for '"' and '`', leaving out the quoting for
mssql, which uses brackets, thus not removing them.

This patch removes mssql quoting style
characters from the join part to mitigate
this issue, which also make nightly green.
Further there are tests added to cover
these cases.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2