Review main Merged

71904Revert "[TASK] Deprecation free Serializable usage in ObjectStorage"

Christian Kuhn CR +2 V +2 Easy +4 −2 updated 10/20/21, 14:11

Commit message

This reverts commit c7c47956c054ef68e2847b06f15cf69b4025bc2c.

The patch did not make sense: A class that has methods
serialize() and unserialize() and NOT implements \Serializable
interface, will never get these methods invoked when
php function serialize() or unserialize() is called.

So, the two methods have been bogus ever since.

By renaming serialize() to __serialize() and unserialize()
to __unserialize(), we actively activated the exception.
This is reverted now. And both method now have a @todo to
drop them in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Simon Gilli +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Simon Gilli +1
    • Stefan Bürk +1
    • core-ci +1 CI

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 10/20/21, 12:03

  2. Christian Kuhn uploaded patch set 2 10/20/21, 12:04

  3. core-ci voted on patch set 1 V +1 10/20/21, 12:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18383

  4. core-ci voted on patch set 2 V +1 10/20/21, 12:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18384

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/20/21, 12:47

  6. Jochen Roth voted on patch set 2 V +1 CR +1 10/20/21, 12:56

  7. Simon Gilli voted on patch set 2 V +1 CR +1 10/20/21, 13:34

  8. Simon Gilli commented on patch set 2 10/20/21, 13:35

    I'm really wondering why the tests did not fail here, should be fixed asap imho :(
  9. Christian Kuhn voted on patch set 2 V +2 CR +2 10/20/21, 14:10

  10. Christian Kuhn merged patch set 3 10/20/21, 14:11