Review 10.4 Merged

71925[BUGFIX] Translate image dimensions on file replace

Benni Mack CR +2 V +2 Normal +76 −0 updated 12/17/21, 14:52

Commit message

Width and height of an image is stored in translatable metadata
records. These properties are extracted by FAL API when a new image is
uploaded. The TYPO3\CMS\Core\Resource\Index\Indexer::updateIndexEntry
method uses the MetaDataAspect to save the new file dimensions.

As the MetaDataAspect has no support for multi-language, it only updates
the default language. A new PSR-14 event listener is added on
AfterFileMetaDataUpdatedEvent to overcome the lack of translation
support. It updates the width and height of all corresponding
sys_file_metadata translations.

Wrong dimensions leads to rendering issues in the frontend when the
image is cropped as the crop area can't be calculated properly.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2