Review main Merged

71939[BUGFIX] Fix warning when query result is written to csv file

Florian Sommer CR +2 V +2 Easy +2 −2 updated 10/26/21, 21:28

Commit message

The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following warning:

  fputcsv(): enclosure must be a character

To prevent this, the header line should also be surrounded by quotation
marks.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Torben Hansen +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Sybille Peters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1315

  1. Florian Sommer uploaded patch set 1 10/22/21, 14:24

  2. core-ci voted on patch set 1 V +1 10/22/21, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18425

  3. Guido Schmechel voted on patch set 1 CR +1 10/23/21, 13:06

  4. Oliver Klee voted on patch set 1 CR +1 10/24/21, 08:13

  5. Sybille Peters voted on patch set 1 V +1 10/24/21, 08:49

  6. Andreas Kienast commented on patch set 1 CR -1 10/24/21, 09:32

    QueryView.php:528

    These arguments are the method's default values and thus can be omitted. I'll update the patch.
  7. Andreas Kienast uploaded patch set 2 10/24/21, 09:33

  8. core-ci voted on patch set 2 V +1 10/24/21, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18486

  9. Guido Schmechel voted on patch set 2 CR +1 10/24/21, 10:02

  10. Oliver Klee voted on patch set 2 CR +1 10/24/21, 10:18

  11. Sybille Peters voted on patch set 2 V +1 10/24/21, 10:43

  12. Torben Hansen voted on patch set 2 CR +1 10/26/21, 05:34

  13. Stefan Bürk commented on patch set 2 V +1 CR +1 10/26/21, 21:27

    QueryView.php:528 Reply

    Done
  14. Christian Kuhn voted on patch set 2 V +2 CR +2 10/26/21, 21:28

  15. Christian Kuhn merged patch set 3 10/26/21, 21:28