Review main Merged

71940[BUGFIX] Deprecation free ArrayObject usage in backend tree

Stefan Bürk CR +2 V +2 Easy +4 −0 updated 10/23/21, 18:36

Commit message

Classes TreeeNodeCollection and SortedTreeNodeCollection
extends ArrayObject and override some methods.

PHP 8.1 added concrete return types to internal objects
and methods which fails if extending classes do not have
compatible return types.

This patch adds the PHP 8.1 attribute #[\ReturnTypeWillChange]
to mitigate these fatal errors, as we cannot change the
return type yet without being breaking. Thus added @todo
to change the return types as breaking change in v12.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2