Review main Merged

71942[BUGFIX] Avoid incomplete setup in ExtensionStatusTest

Stefan Bürk CR +2 V +2 Easy +25 −5 updated 10/23/21, 18:38

Commit message

Since PHP 8.1 passing null as first argument
($format) has been deprecated. LanguageService
uses 'sprintf()' for  formatting messages.

In normal instances LanguageService would
return translated keys, or at least an empty
string.

Tests in ExtensionStatusTest has been mocking
the LanguageService, without correctly mocking
some methods, thus return null on translation.
This leads to 'sprintf()' calls with null
instead of empty strings, thus spawning these
depcrecation messages.

This patch add mocks for some methods of the
LanguageService mock to avoid these messages.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1