Review main Merged

71945[BUGFIX] Use lolli42/finediff over cogpowered/finediff

Christian Kuhn CR +2 V +2 Normal +70 −60 updated 10/23/21, 21:30

Commit message

finediff is used in various core places to render
a HTML "diff" view of two strings. The library didn't
see changes since 2014. With PHP 8.1, it started mumbling
about \ArrayAccess signature shenanigans.

We forked the lib to lolli42/finediff as drop-in
replacement, modernized the codebase a bit and added
multibyte support along the way - that's the reason this
patch is a bug fix.

composer req lolli42/finediff:^1.0
composer rem cogpowered/finediff
composer req lolli42/finediff:^1.0 -d typo3/sysext/core --no-update
composer rem cogpowered/finediff -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1013

  1. Christian Kuhn uploaded patch set 1 10/23/21, 16:51

  2. Christian Kuhn updated the commit message in patch set 2 10/23/21, 16:56

  3. core-ci voted on patch set 1 V +1 10/23/21, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18451

  4. core-ci voted on patch set 2 V +1 10/23/21, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18452

  5. Stefan Bürk commented on patch set 2 CR -1 10/23/21, 17:37

    Replace in 'typo3/sysext/core/composer.json' missed ?
  6. Stefan Bürk uploaded patch set 3 10/23/21, 17:52

  7. core-ci voted on patch set 3 V +1 10/23/21, 18:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18455

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 10/23/21, 18:16

  9. Simon Gilli voted on patch set 3 V +1 CR +1 10/23/21, 20:37

  10. Christian Kuhn commented on patch set 3 10/23/21, 20:44

    note: will pick this to v11. v10 may have a pick as separate patch, too.
  11. Benni Mack voted on patch set 3 V +1 CR +1 10/23/21, 20:46

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 10/23/21, 21:30

  13. Christian Kuhn merged patch set 4 10/23/21, 21:30