Review main Merged

71949[BUGFIX] Ensure type inheritance compatibility for RouteResultInterface

Stefan Bürk CR +2 V +2 Easy +25 −0 updated 10/23/21, 23:39

Commit message

PageArguments and SiteRouteResult implementing the
\ArrayAccess interface indirectly through implementing
RouteResultInterface, but do not have set parameter
and return type for some methods. This could not be done
as mixed is only availabe since PHP 8.0.

PHP 8.1 implemented concrete return types for internal
classes, interfaces and methods which triggers deprecation
messages, unless they are part on an inheritance.

This patch adds the #[\ReturnTypeWillChange] attribute
to suppress the message for PHP 8.1, but ensure the
compatibility for PHP 7.4.

Further @todo's are added to remove #[\ReturnTypeWillChange]
and add concrete return types and parameter types as
breaking change in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/23/21, 20:33

  2. core-ci voted on patch set 1 V +1 10/23/21, 20:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18466

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 21:03

  4. Simon Gilli voted on patch set 1 V +1 CR +1 10/23/21, 21:24

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 21:29

  6. Christian Kuhn merged patch set 2 10/23/21, 21:29