Review main Merged

71950[BUGFIX] Avoid passing null as parameter to trim()

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/23/21, 21:29

Commit message

To make units test notice free in #85092 a wrong
fallback for array access has been used.

Fallback to null and passing to trim() through
null coalescing operator has been the wrong choice,
as it triggers a deprecation message in PHP 8.1.

This patch change the fallback to an empty string
instead to avoid this deprecation message.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1