Review main Merged

71953[BUGFIX] Deprecation free \Iterator in LazyLoadingProxy

Stefan Bürk CR +2 V +2 Easy +10 −1 updated 10/23/21, 22:40

Commit message

PHP 8.1 added concrete return types to internal
interfaces, classes and methods which triggers
deprecation messages, or fatal if it is related
to inheritance or interface implementations.

There are two ways to mitigate this:

* add concrete return type
* add #[\ReturnTypeWillChange]

Adding concrete return types would be breaking,
thus this patch adds #[\ReturnTypeWillChange]
to methods related to the \Iterator interface,
which LazyLoadingProxy implements.

Further @todo comments are added to remove
the php attribute #[\ReturnTypeWillChange]
and add concrete return types as breaking
change in v12.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Stefan Bürk uploaded patch set 1 10/23/21, 22:08

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 10/23/21, 22:20

  3. core-ci voted on patch set 1 V +1 10/23/21, 22:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18474

  4. Simon Gilli voted on patch set 1 V +1 CR +1 10/23/21, 22:32

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/23/21, 22:40

  6. Christian Kuhn merged patch set 2 10/23/21, 22:40