Review main Merged

71963[BUGFIX] Deprecation free \Countable in FileCollector

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 10/24/21, 17:22

Commit message

Set int return type for @internal class FileCollector
to satisfy PHP 8.1 strict return on SPL classes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 10/24/21, 10:49

  2. core-ci voted on patch set 1 V +1 10/24/21, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18494

  3. Nikita Hovratov commented on patch set 1 10/24/21, 16:19

    Can't we change the return type right away, as this class is internal?
  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/24/21, 16:36

  5. Christian Kuhn uploaded patch set 2 10/24/21, 17:07

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 10/24/21, 17:08

  7. core-ci voted on patch set 2 V +1 10/24/21, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18506

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 10/24/21, 17:22

  9. Christian Kuhn merged patch set 3 10/24/21, 17:22