Review main Merged

71964[BUGFIX] Suppress deprecation in EmptyFileSearchResult

Nikita Hovratov CR +2 V +2 Easy +4 −0 updated 10/24/21, 17:11

Commit message

Since PHP 8.1 The Countable interface has tentative
return types. This means mismatching return types
trigger deprecation notices. The methods current
and key of EmptyFileSearchResult have the mismatching
return type void. To suppress the deprecation
without a breaking change, the #[\ReturnTypeWillChange]
attribute has been added to those methods.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1