Review main Merged

71971[BUGFIX] Avoid str_replace(..., null) in AbstractMenuContentObject

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/25/21, 20:18

Commit message

PHP 8.1 emits E_DEPRECATED if second argument to
str_replace() is null. Adapt a null coalescence
and add a cast to string for TSFE->page['uid']
in AbstractMenuContentObject to avoid this.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/25/21, 18:38

  2. core-ci voted on patch set 1 V +1 10/25/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18553

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/25/21, 19:23

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/25/21, 20:10

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/25/21, 20:18

  6. Christian Kuhn merged patch set 2 10/25/21, 20:18