Review main Merged

71973[BUGFIX] Avoid str_replace(..., null) in ContentObjectRenderer

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/25/21, 20:19

Commit message

Calling str_replace() with second argument non-string is
deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in
ContentObjectRenderer to avoid a case found by unit tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/25/21, 19:14

  2. Benni Mack voted on patch set 1 V +1 CR +1 10/25/21, 19:23

  3. core-ci voted on patch set 1 V +1 10/25/21, 19:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18556

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/25/21, 20:12

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/25/21, 20:19

  6. Christian Kuhn merged patch set 2 10/25/21, 20:19