Review main Merged

71981[TASK] Apply current recommendations for BASH scripts

Simon Gilli CR +2 V +2 Normal +65 −63 updated 11/15/21, 14:02

Commit message

This patch applies the current recommendations for BASH scripts see
https://github.com/koalaman/shellcheck#readme.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Simon Gilli uploaded patch set 1 10/26/21, 16:25

  2. core-ci voted on patch set 1 V +1 10/26/21, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18573

  3. Simon Gilli updated the commit message in patch set 2 11/12/21, 11:23

  4. Simon Gilli commented on patch set 2 11/12/21, 11:23

    This change is ready for review.
  5. core-ci voted on patch set 2 V +1 11/12/21, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19205

  6. Oliver Klee voted on patch set 2 CR +1 11/12/21, 12:38

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 11/14/21, 12:18

  8. Georg Ringer voted on patch set 2 V +1 CR +1 11/15/21, 06:42

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 11/15/21, 14:01

  10. Christian Kuhn merged patch set 3 11/15/21, 14:02