Review main Merged

71982[BUGFIX] Avoid warning in ContentObjectRenderer

Christoph Lehmann CR +2 V +2 Easy +2 −2 updated 10/26/21, 21:32

Commit message

getData() may emit E_WARNING accessing $tsfe->page and
$config. Sanitize that by null coalescing to empty
string.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1724

  1. Christoph Lehmann uploaded patch set 1 10/26/21, 16:56

  2. Christian Kuhn commented on patch set 1 10/26/21, 17:14

    ContentObjectRenderer.php:4358

    not entirely sure at first look, but getData() annotation says it returns strings ... maybe null coalescence to empty string instead?
  3. core-ci voted on patch set 1 V +1 10/26/21, 17:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18576

  4. Christian Kuhn uploaded patch set 2 10/26/21, 20:25

  5. Christian Kuhn commented on patch set 2 10/26/21, 20:25

    ContentObjectRenderer.php:4358 Reply

    Done
  6. Stefan Bürk voted on patch set 2 V +1 CR +1 10/26/21, 20:26

  7. Christian Kuhn updated the commit message in patch set 3 10/26/21, 20:29

  8. Christian Kuhn updated the commit message in patch set 4 10/26/21, 20:30

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 10/26/21, 20:30

  10. Christoph Lehmann uploaded patch set 5 10/26/21, 20:33

  11. Christian Kuhn updated the commit message in patch set 6 10/26/21, 20:36

  12. Christoph Lehmann commented on patch set 6 10/26/21, 20:37

    👍
  13. Christian Kuhn updated the commit message in patch set 7 10/26/21, 20:37

  14. Christian Kuhn commented on patch set 7 10/26/21, 20:37

    sorry for changing commit message so often and quickly ...
  15. core-ci voted on patch set 2 V +1 10/26/21, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18592

  16. core-ci voted on patch set 3 V +1 10/26/21, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18593

  17. core-ci voted on patch set 6 V +1 10/26/21, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18596

  18. core-ci voted on patch set 5 V +1 10/26/21, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18595

  19. core-ci voted on patch set 7 V +1 10/26/21, 21:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18597

  20. core-ci voted on patch set 4 V +1 10/26/21, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18594

  21. Stefan Bürk voted on patch set 7 V +1 CR +1 10/26/21, 21:19

  22. Wouter Wolters voted on patch set 7 V +1 CR +1 10/26/21, 21:23

  23. Christian Kuhn voted on patch set 7 V +2 CR +2 10/26/21, 21:32

  24. Christian Kuhn merged patch set 8 10/26/21, 21:32