Review main Merged

71985[BUGFIX] Drop a strange internal DataHandler method

Christian Kuhn CR +2 V +2 Easy +2 −27 updated 10/26/21, 20:31

Commit message

That's a seldom gem.

Method convNumEntityToByteValue() in DataHandler
is *seriously* strange. It exists since very early
TYPO3 claiming to fix a "very rare" MSIE bug. It
*tries* to convert the "{" of a string like
"foo{bar" to an ascii char ("{") and does
this with a weird logic that includes a microtime().

Testing this thing locally reveals the method
returns different results per execution!

The patch drops that @internal method and it's
caller.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2