Review 10.4 Merged

71990[BUGFIX] Fix warning when query result is written to csv file

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/26/21, 21:44

Commit message

The function fputcsv gets an enclosure as third parameter. Providing an
empty string as enclosure leads to following warning:

  fputcsv(): enclosure must be a character

To prevent this, the header line should also be surrounded by quotation
marks.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 10/26/21, 21:28

  2. core-ci voted on patch set 1 V +1 10/26/21, 21:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18602

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 10/26/21, 21:44

  4. Christian Kuhn merged patch set 2 10/26/21, 21:44