Review main Merged

71992[BUGFIX] Prepare doctrine facades towards PHP 8.1

Christian Kuhn CR +2 V +2 Easy +19 −15 updated 10/27/21, 18:59

Commit message

\PDO::quote() is picky about the type argument
in PHP 8.1. doctrine/dbal partially works around
that and will improve with upcoming releases in
this area. Our facade classes should still sanitize
null arguments in a backwards compatible way.

The patch adjusts signatures of quote() and literal()
and explitictly avoids handing null to doctrine and
lower level PDO methods.

A unit test prophecy dealing with defaults needs
to be adjusted along the way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3