Review main Merged

71998[BUGFIX] Use CodeMirror auto sizing feature correctly

Nikita Hovratov CR +2 V +2 Easy +7 −6 updated 11/03/21, 19:45

Commit message

To use CodeMirror's auto sizing feature, we need
to set the style attribute of the wrapper element
to "auto", instead of providing the "height" option.

In a previous patch a related issue was fixed by
setting the height to the remaining space of the
frame. This led to another issue, which occurs,
when there is already little space left.

Both is fixed by using the auto sizing option
correctly and even gives us the benefit of
automatic resizing, when changing the editor's
content.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3