72011[BUGFIX] Sanitize calling htmlspecialchars(...) in FormViewHelper
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1518
-
Stefan Bürk uploaded patch set 1 10/30/21, 18:26
-
Oliver Klee voted on patch set 1 CR +1 10/30/21, 18:31
-
core-ci voted on patch set 1 V +1 10/30/21, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18683
-
Georg Ringer voted on patch set 1 V +1 CR +1 11/01/21, 10:27
-
Andreas Kienast updated the commit message in patch set 2 11/01/21, 10:38
-
Andreas Kienast voted on patch set 2 V +1 CR +1 11/01/21, 10:40
-
Oliver Klee voted on patch set 2 CR +1 11/01/21, 10:52
-
core-ci voted on patch set 2 V +1 11/01/21, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18714
-
Nikita Hovratov commented on patch set 2 V +1 CR -1 11/01/21, 14:08
Works, but want to know, if we can fix it at another point.FormViewHelper.php:174$this->arguments['hiddenFieldClassName'] can't be null here.FormViewHelper.php:279Maybe we should fix it here? https://github.com/TYPO3/typo3/blob/4362e632da79223d61e06ea2e47f5f98dd635d73/typo3/sysext/extbase/Classes/Mvc/ExtbaseRequestParameters.php#L44 @lolli added a todo here to initialize with an empty string. -
Stefan Bürk commented on patch set 2 11/03/21, 15:23
Thx Nikita for the review and the inputs. Will recheck this later after work, last day's were busy with work. -
Stefan Bürk commented on patch set 2 11/03/21, 19:32
FormViewHelper.php:174ReplyAck. Will revert this then.FormViewHelper.php:279ReplyHave checked, initialzing that property as string would fix it also, so the changes here are unneed. Will try to ping @lolli why he added only a @todo, if he has seen any sideeffect which I/we could no see - or it is safe to change it there. -
Stefan Bürk uploaded patch set 3 11/03/21, 20:10
-
Stefan Bürk commented on patch set 3 11/03/21, 20:11
FormViewHelper.php:174ReplyDone -
Oliver Klee voted on patch set 3 CR +1 11/03/21, 20:19
-
core-ci voted on patch set 3 V +1 11/03/21, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18825
-
Christian Kuhn commented on patch set 3 V +1 CR +1 11/03/21, 20:25
FormViewHelper.php:279Reply UnresolvedChanging this in ExtbaseRequestParameters by solving the @todo is imho a bit too risky in v11 - I'm simply not 100% sure we don't raise side effects doing this. I'd thus go with the change as proposed in v11. v12 will see breaking changes in ExtbaseRequestParameters and extbase request classes - let's solve the todo at this point in time. -
Anja Leichsenring voted on patch set 3 V +2 CR +2 11/03/21, 20:26
-
Anja Leichsenring merged patch set 4 11/03/21, 20:26