Review main Merged

72012[BUGFIX] Sanitize calling htmlspecialchars(...) in SelectViewHelper

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 11/02/21, 13:05

Commit message

htmlspecialchars(...) expects that first argument is a string,
otherwise triggering E_DEPRECATED.

This patch adds a string cast to ensure value is passed as string
to htmlspecialchars(...) in SelectViewHelper.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Stefan Bürk uploaded patch set 1 10/30/21, 18:28

  2. Oliver Klee voted on patch set 1 CR +1 10/30/21, 18:30

  3. core-ci voted on patch set 1 V +1 10/30/21, 18:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18684

  4. Georg Ringer voted on patch set 1 V +1 CR +1 11/01/21, 10:28

  5. Andreas Kienast updated the commit message in patch set 2 11/01/21, 10:38

  6. Andreas Kienast updated the commit message in patch set 3 11/01/21, 10:39

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 11/01/21, 10:39

  8. Oliver Klee voted on patch set 3 CR +1 11/01/21, 10:52

  9. core-ci voted on patch set 2 V +1 11/01/21, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18713

  10. core-ci voted on patch set 3 V +1 11/01/21, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18716

  11. Nikita Hovratov commented on patch set 3 V +1 CR +1 11/01/21, 13:52

    $value seems to be always a string, but it's ok I guess.
  12. Andreas Kienast voted on patch set 3 V +2 CR +2 11/02/21, 13:05

  13. Andreas Kienast merged patch set 4 11/02/21, 13:05