Review main Merged

72015[BUGFIX] Fix Frontend translations for file metadata in free mode

Alexander Stehlik CR +2 V +2 Hard +255 −11 updated 04/10/25, 20:28

Commit message

When rendering a frontend in a language set to free
mode (= just do a SQL query for e.g. language=5), sys_file_metadata
is now also shown in the frontend's language.

The logic within FileMetadataAspect is always loading the
default language (L=0) and for this, we need to call
PageRepository->getLanguageOverlay() for "sys_file_metadata"
and even when running in free mode, handle a "translation"
for sys_file_metadata just like we'd do overlays.

This is the same concept that TYPO3 needs to use for pages
(page always resolves to a default language record).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 3148

Show 1523 earlier messages
  1. Alexander Stehlik uploaded patch set 1 10/31/21, 18:22

  2. core-ci voted on patch set 1 V -1 10/31/21, 18:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18701

  3. Alexander Stehlik uploaded patch set 2 10/31/21, 18:34

  4. core-ci voted on patch set 2 V -1 10/31/21, 18:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18704

  5. Alexander Stehlik uploaded patch set 3 10/31/21, 19:31

  6. core-ci voted on patch set 3 V -1 10/31/21, 19:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18706

  7. Alexander Stehlik uploaded patch set 4 10/31/21, 19:35

  8. core-ci voted on patch set 4 V +1 10/31/21, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18707

  9. anonymized-52878 commented on patch set 4 V +1 CR +1 11/02/21, 13:25

    Tested the patch. It works like expected.
  10. Alexander Stehlik updated the commit message in patch set 5 11/02/21, 13:27

  11. Alexander Stehlik commented on patch set 5 11/02/21, 13:28

    Thank you for testing. I mark this as WIP because I need to create a pull request for the testing framework before this can be merged.
  12. core-ci voted on patch set 5 V +1 11/02/21, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18761

  13. Benni Mack updated the commit message in patch set 6 11/18/21, 10:42

  14. core-ci voted on patch set 6 V +1 11/18/21, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19455

  15. Benni Mack wrote 11/29/21, 10:16

    Change destination moved from master to main
  16. Benni Mack updated the commit message in patch set 7 11/29/21, 14:02

  17. core-ci voted on patch set 7 V +1 11/29/21, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20076

  18. Benni Mack commented on patch set 7 12/20/21, 08:16

    Hey Alex, I think if we set up PageRepository properly, we can simply use `getLanguageOverlay()` once or did I miss anything here?
  19. Benni Mack commented on patch set 7 01/31/22, 12:38

    Alex, any new on this? What Testing Framework change is needed?
  20. Benni Mack commented on patch set 7 03/14/22, 15:25

    ping. any news?
  21. Benni Mack updated the commit message in patch set 8 V +1 05/03/23, 09:16

  22. core-ci voted on patch set 8 V -1 05/03/23, 09:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41387

  23. Benni Mack abandoned the change 07/31/23, 13:41

    abandoning this change for the time being due to lack of feedback
  1. Benni Mack restored the change 12/16/24, 16:52

  2. Benni Mack uploaded patch set 9 V -1 12/16/24, 16:52

  3. core-ci voted on patch set 9 V -1 12/16/24, 17:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71214

  4. Benni Mack rebased onto patch set 10 V -1 12/19/24, 20:42

  5. core-ci voted on patch set 10 V -1 12/19/24, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71473

  6. Benni Mack rebased onto patch set 11 V -1 04/10/25, 07:21

  7. core-ci voted on patch set 11 V -1 04/10/25, 07:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77392

  8. Benni Mack uploaded patch set 12 V -1 04/10/25, 08:46

  9. core-ci voted on patch set 12 V -1 04/10/25, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77414

  10. Benni Mack uploaded patch set 13 V -1 04/10/25, 10:30

  11. Benni Mack commented on patch set 13 04/10/25, 10:31

    Reply

    found it
  12. core-ci voted on patch set 13 V -1 04/10/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77428

  13. Stefan Bürk uploaded patch set 14 V -1 04/10/25, 11:33

  14. core-ci voted on patch set 14 V +1 04/10/25, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77433

  15. Stefan Bürk uploaded patch set 15 V +1 04/10/25, 11:50

  16. core-ci voted on patch set 15 V +1 04/10/25, 11:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77434

  17. Stefan Bürk uploaded patch set 16 V +1 04/10/25, 19:25

  18. core-ci voted on patch set 16 V +1 04/10/25, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77463

  19. Benni Mack updated the commit message in patch set 17 V +1 04/10/25, 20:01

  20. Benni Mack voted on patch set 17 CR +1 V +1 04/10/25, 20:02

  21. core-ci voted on patch set 17 V +1 04/10/25, 20:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77468

  22. Stefan Bürk voted on patch set 17 CR +2 V +2 04/10/25, 20:10

  23. Stefan Bürk commented on patch set 17 CR -1 04/10/25, 20:17

    Backport needs adoption and verification.
  24. Stefan Bürk voted on patch set 17 CR +2 04/10/25, 20:28

  25. Stefan Bürk merged patch set 18 04/10/25, 20:28