Review main Merged

72027[BUGFIX] Ensure form finisher dependencies can get injected

Elias Häußler CR +2 V +2 Easy +23 −8 updated 11/05/21, 05:35

Commit message

With #94317 the instantiation of form finishers has been changed by
replacing `ObjectManager::get()` in favor of
`GeneralUtility::makeInstance()`. However, since form finishers are
not public by default it was impossible to inject required
dependencies into it.

This patch ensures dependencies of form finishers can
be injected by making them available through the symfony dependency
injection container.

As finishers contain state (setOptions()), they are marked as not
shared.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 2