72030[BUGFIX] Prevent array to string conversion in IconFactory
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Rudy Gnodde +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 910
-
Robert Kärner uploaded patch set 1 11/03/21, 09:38
-
core-ci voted on patch set 1 V +1 11/03/21, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18775
-
Rudy Gnodde voted on patch set 1 CR +1 11/03/21, 10:24
-
Benni Mack voted on patch set 1 CR +1 11/03/21, 11:30
-
Christian Kuhn voted on patch set 1 V +1 CR +1 11/03/21, 12:17
-
Oli Bartsch voted on patch set 1 V +1 CR +1 11/03/21, 12:24
-
Christian Kuhn voted on patch set 1 V +2 CR +2 11/03/21, 12:24
-
Christian Kuhn merged patch set 2 11/03/21, 12:25
-
Simon Schaufelberger commented on patch set 2 11/03/21, 13:06
This bug also exists in 10.4 and has been forgotten in the "Releases" -
Robert Kärner commented on patch set 2 11/03/21, 13:23
Reply
10.4 is not affected, as it doesn't support PHP 8.0; and this array to string conversion warning is only appearing on PHP 8.0 and higher. It used to be a notice on lower PHP versions.