Review main Merged

72040[TASK] Fix phpstan errors from ReturnTypeRule in various exts

Benni Mack CR +2 V +2 Easy +18 −19 updated 04/21/26, 15:04

Commit message

* EXT:belog
* EXT:beuser
* EXT:dashboard
* EXT:extensionmanager

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1722

  1. Benni Mack uploaded patch set 1 11/03/21, 19:37

  2. core-ci voted on patch set 1 V -1 11/03/21, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18821

  3. Oliver Klee commented on patch set 1 11/03/21, 20:58

    This "in in" looks out of place here.
  4. Oliver Klee commented on patch set 1 11/03/21, 21:00

    ExtensionRepository.php:109

    Can the findOneBy* methods also return null?
  5. Benni Mack updated the commit message in patch set 2 11/08/21, 15:54

  6. core-ci voted on patch set 2 V -1 11/08/21, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19027

  7. Christian Kuhn commented on patch set 2 11/09/21, 19:16

    Reply

    Done

    ExtensionRepository.php:109 Reply

    Done
  8. Christian Kuhn uploaded patch set 3 11/09/21, 19:16

  9. Georg Ringer commented on patch set 3 V +1 CR +1 11/09/21, 19:20

    Extension.php:668

    fix what
  10. Christian Kuhn uploaded patch set 4 11/09/21, 19:25

  11. Christian Kuhn commented on patch set 4 11/09/21, 19:25

    Extension.php:668 Reply

    Unsure. Dropped comment.
  12. core-ci voted on patch set 3 V -1 11/09/21, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19085

  13. core-ci voted on patch set 4 V -1 11/09/21, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19086

  14. Christian Kuhn commented on patch set 4 11/09/21, 19:42

    ac tests & phpstan unhappy ... guess i did something wrong?
  15. Christian Kuhn uploaded patch set 5 11/10/21, 10:52

  16. core-ci voted on patch set 5 V +1 11/10/21, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19119

  17. Oliver Klee voted on patch set 5 CR +1 11/10/21, 11:49

  18. Christian Kuhn voted on patch set 5 V +1 CR +1 11/10/21, 12:28

  19. Stefan Bürk voted on patch set 5 V +1 CR +1 11/10/21, 17:24

  20. Benni Mack voted on patch set 5 V +2 CR +2 11/10/21, 17:24

  21. Benni Mack merged patch set 6 11/10/21, 17:24

  22. Sascha Egerer commented on patch set 6 11/10/21, 17:38

    LogEntry.php:123 Unresolved

    For phpstan this could be resolved by adding `@phpstan-var string|int`