72040[TASK] Fix phpstan errors from ReturnTypeRule in various exts
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php1+2 −2
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −1
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+2 −3
- typo3/sysext/beuser/Classes/Domain/Repository/BackendUserSessionRepository.php+1 −1
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php+1 −1
- typo3/sysext/dashboard/Classes/DashboardInitializationService.php+1 −0
- typo3/sysext/dashboard/Classes/DashboardRepository.php+2 −3
- typo3/sysext/extensionmanager/Classes/Controller/AbstractModuleController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Dependency.php+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/Extension.php2+1 −1
- typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php2+3 −3
- typo3/sysext/extensionmanager/Classes/Service/ComposerManifestProposalGenerator.php+1 −1
Review log 1722
-
Benni Mack uploaded patch set 1 11/03/21, 19:37
-
core-ci voted on patch set 1 V -1 11/03/21, 19:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18821
-
Oliver Klee commented on patch set 1 11/03/21, 20:58
This "in in" looks out of place here. -
Oliver Klee commented on patch set 1 11/03/21, 21:00
ExtensionRepository.php:109Can the findOneBy* methods also return null? -
Benni Mack updated the commit message in patch set 2 11/08/21, 15:54
-
core-ci voted on patch set 2 V -1 11/08/21, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19027
-
Christian Kuhn commented on patch set 2 11/09/21, 19:16
Reply
DoneExtensionRepository.php:109ReplyDone -
Christian Kuhn uploaded patch set 3 11/09/21, 19:16
-
Georg Ringer commented on patch set 3 V +1 CR +1 11/09/21, 19:20
Extension.php:668fix what -
Christian Kuhn uploaded patch set 4 11/09/21, 19:25
-
Christian Kuhn commented on patch set 4 11/09/21, 19:25
Extension.php:668ReplyUnsure. Dropped comment. -
core-ci voted on patch set 3 V -1 11/09/21, 19:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19085
-
core-ci voted on patch set 4 V -1 11/09/21, 19:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19086
-
Christian Kuhn commented on patch set 4 11/09/21, 19:42
ac tests & phpstan unhappy ... guess i did something wrong? -
Christian Kuhn uploaded patch set 5 11/10/21, 10:52
-
core-ci voted on patch set 5 V +1 11/10/21, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19119
-
Oliver Klee voted on patch set 5 CR +1 11/10/21, 11:49
-
Christian Kuhn voted on patch set 5 V +1 CR +1 11/10/21, 12:28
-
Stefan Bürk voted on patch set 5 V +1 CR +1 11/10/21, 17:24
-
Benni Mack voted on patch set 5 V +2 CR +2 11/10/21, 17:24
-
Benni Mack merged patch set 6 11/10/21, 17:24
-
Sascha Egerer commented on patch set 6 11/10/21, 17:38
LogEntry.php:123UnresolvedFor phpstan this could be resolved by adding `@phpstan-var string|int`