Review main Merged

72048[BUGFIX] Fix too long regular expression error in ContentObjectRenderer

Anja Leichsenring CR +2 V +2 Normal +60 −19 updated 11/10/21, 18:57

Commit message

Text cropping on texts with way more than 1000 characters
triggers regular expression compilation errors.
The sweet spot was determined to a value of max 962 characters,
thus leading to internal 'preg_match' error state and throwing
'Compilation failed: regular expression is too large' warning.

The patch crops text in multiple chunks and reassembles the
chunks until crop position was reached to avoid this internal
error exceeding the max regular expression pattern length.

Further tests are added to cover this scenario.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2