Review main Merged

72049[TASK] Set actions to protected in Dashboard

Jochen Roth CR +2 V +2 Easy +7 −7 updated 11/04/21, 14:20

Commit message

Currently all "*Action" are set to public which isn't
neccessary because the handleRequest() dispatches
these actions.

This has been fixed by setting all these methods
to protected.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Jochen Roth uploaded patch set 1 11/04/21, 11:51

  2. Benni Mack voted on patch set 1 V +1 CR +1 11/04/21, 11:55

  3. core-ci voted on patch set 1 V -1 11/04/21, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18872

  4. Benni Mack rebased onto patch set 2 11/04/21, 13:45

  5. core-ci voted on patch set 2 V +1 11/04/21, 14:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18883

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 11/04/21, 14:08

  7. Guido Schmechel voted on patch set 2 CR +1 11/04/21, 14:14

  8. Benni Mack voted on patch set 2 V +2 CR +2 11/04/21, 14:20

  9. Benni Mack merged patch set 3 11/04/21, 14:20