Review main Merged

72056[TASK] Simplify checkbox items TCA

Nikita Hovratov CR +2 V +2 Hard +35 −294 updated 11/10/21, 09:13

Commit message

TCA shares same keys across different types,
and so does "items" with type check, radio
and select. The value is usually set for the
array key "1". But type check is special in
that regard: the value is stored as a bitset.
This means, the value is completely unused
and shall not be provided for checkboxes.

1. All occurrences of "items => ['1' => '']"
   removed.

2. When checkboxes only have 1 item and no
   configuration whatsoever, "items" can be
   omitted. These constructs are gone now:

   'items' => [
       [
            0 => '',
            1 => '',
       ],
    ]

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 29

Show 9 more files