Review main Merged

72069[BUGFIX] Cast tokenValue to string in ext:impexp

TYPO3com CR +2 V +2 Easy +3 −2 updated 11/09/21, 17:37

Commit message

Cast 'tokenValue' to string as it can happen to be an integer.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 814

  1. TYPO3com uploaded patch set 1 11/05/21, 15:55

  2. core-ci voted on patch set 1 V +1 11/05/21, 16:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18963

  3. Christian Kuhn updated the commit message in patch set 2 11/09/21, 16:58

  4. Christian Kuhn uploaded patch set 3 11/09/21, 17:00

  5. Oli Bartsch commented on patch set 3 11/09/21, 17:06

    Import.php:1564

    We might want to use a local variable instead of type casting the same thing two times.
  6. Christian Kuhn uploaded patch set 4 11/09/21, 17:08

  7. Christian Kuhn commented on patch set 3 11/09/21, 17:08

    Import.php:1564 Reply

    Done
  8. core-ci voted on patch set 2 V +1 11/09/21, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19074

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 11/09/21, 17:13

  10. core-ci voted on patch set 3 V -1 11/09/21, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19075

  11. core-ci voted on patch set 4 V +1 11/09/21, 17:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19077

  12. core-ci voted on patch set 3 V +1 11/09/21, 17:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19075

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 11/09/21, 17:37

  14. Oli Bartsch merged patch set 5 11/09/21, 17:37