Review main Merged

72071[TASK] Move Composer package artifact to vendor folder

Simon Gilli CR +2 V +2 Easy +22 −9 updated 11/15/21, 22:39

Commit message

Storing the package artifact in the var/build folder raised
questions how this folder shall be treated in general and during
deployment. Since the Package Artifact is built in
a `composer install` process, it should be treated the same as
other build artifacts like all files in the vendor folder.

To make this more clear, the package artifact is now also stored in
the vendor folder.

Accessing the vendor folder during runtime is now possible with
using Composer 2.1 runtime API, which is required anyway already.

The path to the vendor folder is determined indirectly, by using
the path to the typo3/cms-composer-installers package. This means,
this package must not be replaced by another package with a different
name. Since no public replacements for this package exist and
there are no benefits for a private replacement of this package over
having a private fork with the same package name,
this should not be an impediment.

To ease the required related changes in the testing framework,
late static binding is used for calling
SystemEnvironmentBuilder::usesComposerClassLoading

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5