Review 10.4 Merged

72075[TASK] Change requirement for finediff

Sybille Peters CR +2 V +2 Normal +70 −60 updated 11/08/21, 11:01

Commit message

Change requirement from cogpowered/finediff to lolli42/finediff.
This was already done for v11 - due to problems with PHP 8
in the lib cogpowerd/finediff.

Additionally, due to strict type checking, a cast to string
must be perfomed in DiffUtility::makeDiffDisplay().

The new library also comes with better support for multibyte
strings and still supports PHP 7.2 so it can be used in
v10 as well.

Finediff provides an extendable diff functionality
which can be used by extensions as well and is used in the
core in the DiffUtility class.

Since the change for v11 was a bugfix, but for v10 it
is not, change is declared as TASK and a new patch
is created.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 57

  1. Sybille Peters uploaded patch set 1 11/08/21, 04:37

  2. core-ci voted on patch set 1 V +1 11/08/21, 04:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19001

  3. Sybille Peters uploaded patch set 2 11/08/21, 04:48

  4. core-ci voted on patch set 2 V +1 11/08/21, 05:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19002

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 11/08/21, 10:56

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 11/08/21, 11:01

  7. Oli Bartsch merged patch set 3 11/08/21, 11:01