Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned Breaking

72082[!!!][TASK] Inject ContentDataProcessor into processors

Benjamin Franzke CR -2 V -1 Normal +44 −26 updated 04/21/26, 15:05

Commit message

DataProcessors depend on ContentDataProcessor for
execution of additonal processors, and are therefore
adapted to inject it as a dependency.

They are marked as public via DI to able to be
factored with dependencies injected.

TODO:
 * Add breaking.rst that processors are considered
   stateless, and if not, may now break when not explicitly
   marking as `shared: true`.
   …or decide that stateful processors are a bug (like SiteProcessor
   which is fixed)

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 6
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/72082/6 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/72082/6 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Benjamin Franzke -2
  • Verified V -1 Blocked
    • core-ci -1 CI

Relation chain 2

  1. 72082 [!!!][TASK] Inject ContentDataProcessor into processors This change

  2. main 72029[BUGFIX] Allow service aliases in ContentDataProcessor This change is based on it Merged Benjamin Franzke CR +2 V +2 di Normal +147 −18

Files 7

Review log 915

  1. Benjamin Franzke uploaded patch set 1 11/08/21, 15:58

  2. core-ci voted on patch set 1 V -1 11/08/21, 16:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19028

  3. Benjamin Franzke uploaded patch set 2 11/08/21, 16:17

  4. core-ci voted on patch set 2 V -1 11/08/21, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19029

  5. Benjamin Franzke uploaded patch set 3 11/08/21, 16:29

  6. core-ci voted on patch set 3 V +1 11/08/21, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19031

  7. Thomas Löffler voted on patch set 3 V +1 CR +1 11/09/21, 11:21

  8. Benjamin Franzke commented on patch set 3 CR -2 11/11/21, 12:52

    Services.php:13 Unresolved

    Could unfortunately be breaking because this would make processors proper services, expecting them to not contain state. But typo3/sysext/frontend/Classes/DataProcessing/SiteProcessor.php for example contains a reference to TSFE in the constructor. Thus, once it became a sharable service, it would break subrequests.
  9. Benjamin Franzke uploaded patch set 4 11/11/21, 13:02

  10. Benjamin Franzke uploaded patch set 5 11/11/21, 13:02

  11. core-ci voted on patch set 4 V -1 11/11/21, 13:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19173

  12. core-ci voted on patch set 5 V -1 11/11/21, 13:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19174

  13. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  14. Benni Mack updated the commit message in patch set 6 11/29/21, 13:39

  15. core-ci voted on patch set 6 V -1 11/29/21, 18:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20067