Review main Merged

72095[BUGFIX] Properly respect offset in QueryGenerator

Oli Bartsch CR +2 V +2 Easy +20 −2 updated 11/09/21, 15:54

Commit message

The pagination feature in DB Check "Full search" did
not work, since the defined offset was not added to
the query.

This is now fixed by checking for a comma separated
string, which would therefore contain both an offset
and the limit. In case both values are given, they are
now properly added to the query.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/09/21, 15:01

  2. core-ci voted on patch set 1 V +1 11/09/21, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19068

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/09/21, 15:39

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/09/21, 15:46

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 11/09/21, 15:54

  6. Christian Kuhn merged patch set 2 11/09/21, 15:54