Review main Merged

72106[BUGFIX] Avoid calling htmlspecialchars(null) in InputTextElement

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/10/21, 09:06

Commit message

InputTextElement::render() calls htmlspecialchars() to output the
itemValue. $itemValue can be null null instead of a string at this
place and feeding null to htmlspecialchars() emits a E_DEPRECATED
PHP 8.1 error. Sanitize call.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 610

  1. Stefan Bürk uploaded patch set 1 11/10/21, 07:00

  2. Stefan Bürk updated the commit message in patch set 2 11/10/21, 07:03

  3. core-ci voted on patch set 1 V +1 11/10/21, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19092

  4. core-ci voted on patch set 2 V -1 11/10/21, 07:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19094

  5. core-ci voted on patch set 2 V +1 11/10/21, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19094

  6. Christian Kuhn updated the commit message in patch set 3 11/10/21, 08:27

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 11/10/21, 08:28

  8. core-ci voted on patch set 3 V +1 11/10/21, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19104

  9. Benni Mack voted on patch set 3 V +2 CR +2 11/10/21, 09:06

  10. Benni Mack merged patch set 4 11/10/21, 09:06