Review main Merged

72107[BUGFIX] Avoid calling strlen(null) in TextElement

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 11/10/21, 08:25

Commit message

TextElement::render() calls strlen() to determine length of form
elemet item value. It may be that item value is null instead of a
string at this place and feed null to strlen() emits a E_DEPRECATED
PHP 8.1 error. Sanitize call.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Stefan Bürk uploaded patch set 1 11/10/21, 07:03

  2. core-ci voted on patch set 1 V +1 11/10/21, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19093

  3. Benni Mack voted on patch set 1 V +1 CR +1 11/10/21, 07:53

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 11/10/21, 08:24

  5. Christian Kuhn merged patch set 2 11/10/21, 08:25