Review main Merged

72133[BUGFIX] Avoid E_DEPRECATED error calling trim(null) and explode(null)

Stefan Bürk CR +2 V +2 Easy +2 −2 updated 11/10/21, 09:55

Commit message

TypoScriptTemplateInformationModuleFunctionController::main() calls
trim() and explode() with array values which may be null. Feeding null
for the string arguments of these functions emits a E_DEPRECATED
PHP 8.1 error. Sanitize calls.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Stefan Bürk uploaded patch set 1 11/10/21, 07:13

  2. core-ci voted on patch set 1 V +1 11/10/21, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19100

  3. Christian Kuhn updated the commit message in patch set 2 11/10/21, 09:23

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 11/10/21, 09:24

  5. core-ci voted on patch set 2 V +1 11/10/21, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19114

  6. Wouter Wolters voted on patch set 2 V +1 CR +1 11/10/21, 09:48

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/21, 09:55

  8. Christian Kuhn merged patch set 3 11/10/21, 09:55