Review main Merged

72134[BUGFIX] Avoid calling parse_url(null) in DatabaseRecordList

Stefan Bürk CR +2 V +2 Easy +6 −1 updated 11/10/21, 08:57

Commit message

DatabaseRecordList::renderListRow() calls linkUrlMail() with
eventually null as second argument, thus invoking parse_url(null)
which emits a E_DEPRECATED PHP 8.1 error.

The patch sanitizes call in renderListRow(), adds type casts
in linkUrlMail() and a @todo to change signature in v12.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Stefan Bürk uploaded patch set 1 11/10/21, 07:15

  2. core-ci voted on patch set 1 V +1 11/10/21, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19101

  3. Christian Kuhn updated the commit message in patch set 2 11/10/21, 08:30

  4. Christian Kuhn uploaded patch set 3 11/10/21, 08:33

  5. Christian Kuhn voted on patch set 3 V +1 CR +1 11/10/21, 08:34

  6. core-ci voted on patch set 2 V +1 11/10/21, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19105

  7. core-ci voted on patch set 3 V +1 11/10/21, 08:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19106

  8. Benni Mack voted on patch set 3 V +2 CR +2 11/10/21, 08:57

  9. Benni Mack merged patch set 4 11/10/21, 08:57