Review main Abandoned

72155[WIP][TASK] Log Exceptions in softref parser for invalid user input

Alexander Stehlik CR 0 V 0 Normal +81 −5 updated 06/11/23, 23:18

Commit message

The TypolinkSoftReferenceParser does not throw unhandled Exceptions
any more when the user enters invalid / forbidden URLs in link
fields.

Instead the ocurred errors are catched and written to the syslog
to allow administrators to take appropriate steps.

For Backend requests the errors are also added as flash messages.

WIP:
Adjust tests
Translations for flash messages.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 57

  1. Alexander Stehlik uploaded patch set 1 11/10/21, 21:11

  2. core-ci voted on patch set 1 V -1 11/10/21, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19152

  3. Benni Mack wrote 11/29/21, 10:14

    Change destination moved from master to main
  4. Benni Mack updated the commit message in patch set 2 11/29/21, 13:39

  5. core-ci voted on patch set 2 V -1 11/29/21, 18:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20068

  6. Christian Kuhn commented on patch set 2 06/11/23, 23:18

    hey. i hope it's ok to abandon here for now: this patch is stalled since it's first push and nobody is working on it. for the sake of a more clean review system, we should get rid of it for now. in case work is picked up, a new patch should be created.
  7. Christian Kuhn abandoned the change 06/11/23, 23:18