Review main Merged

72162[TASK] Add correct test for shortcut issue in language menu

Nikita Hovratov CR +2 V +2 Easy +35 −0 updated 11/12/21, 22:54

Commit message

The added tests for #89871 do not prove the
correctness of the patch. They go green, without the
fix being applied. This is a blocker for another
regression bugfix, which depends on these tests.

The issue lied in the language menu, not the normal
menu. For this, a new method createLanguageMenu has
been added to AbstractLocalizedPagesTestCase.php. It
is now used to assure the generated links always
point to the target language and not to the current
one.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 3