Review main Merged

72174[TASK] Activate a unit test with PHP 8.1

Christian Kuhn CR +2 V +2 Easy +0 −8 updated 11/15/21, 13:10

Commit message

There was a skipped unit test due to a PHP 8.1 bug.
Latest rc6 fixed the issue, the test can be activated
again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 11/15/21, 12:25

  2. core-ci voted on patch set 1 V +1 11/15/21, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19293

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 11/15/21, 12:44

  4. Jochen Roth voted on patch set 1 V +1 CR +1 11/15/21, 12:55

  5. Wouter Wolters voted on patch set 1 V +1 CR +1 11/15/21, 12:59

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 11/15/21, 13:10

  7. Christian Kuhn merged patch set 2 11/15/21, 13:10