Review main Merged

72195[BUGFIX] Fix warning in TypoScriptParser

Nikita Hovratov CR +2 V +2 Easy +19 −15 updated 11/27/21, 22:59

Commit message

The method getVal now always returns an array with
a string at index 0 and an array at index 1.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1625

  1. Nikita Hovratov uploaded patch set 1 11/16/21, 18:45

  2. core-ci voted on patch set 1 V -1 11/16/21, 19:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19369

  3. core-ci commented on patch set 1 11/16/21, 19:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19369

  4. Nikita Hovratov uploaded patch set 2 11/16/21, 20:12

  5. core-ci voted on patch set 2 V -1 11/16/21, 20:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19373

  6. Nikita Hovratov uploaded patch set 3 11/16/21, 20:33

  7. core-ci voted on patch set 3 V +1 11/16/21, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19377

  8. Benni Mack updated the commit message in patch set 4 11/18/21, 10:52

  9. core-ci voted on patch set 4 V +1 11/18/21, 12:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19496

  10. Nikita Hovratov rebased onto patch set 5 11/23/21, 13:35

  11. core-ci voted on patch set 5 V +1 11/23/21, 13:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19677

  12. Stefan Bürk voted on patch set 5 CR +1 11/25/21, 19:30

  13. Stefan Bürk commented on patch set 5 CR 0 11/26/21, 18:19

    ContentObjectRenderer.php:728

    This is also superfluous and may be simplefied to simple $conf here, regarding to this patch.
  14. Nikita Hovratov uploaded patch set 6 11/26/21, 18:54

  15. Nikita Hovratov commented on patch set 6 11/26/21, 18:54

    ContentObjectRenderer.php:728 Reply

    Done
  16. core-ci voted on patch set 6 V -1 11/26/21, 18:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19825

  17. Nikita Hovratov uploaded patch set 7 11/26/21, 19:21

  18. core-ci voted on patch set 7 V +1 11/26/21, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19827

  19. Christian Kuhn voted on patch set 7 V +1 CR +1 11/27/21, 22:39

  20. Christian Kuhn uploaded patch set 8 11/27/21, 22:41

  21. Christian Kuhn voted on patch set 8 V +1 CR +1 11/27/21, 22:45

  22. Stefan Bürk voted on patch set 8 V +1 CR +1 11/27/21, 22:45

  23. core-ci voted on patch set 8 V +1 11/27/21, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19903

  24. Christian Kuhn voted on patch set 8 V +2 CR +2 11/27/21, 22:59

  25. Christian Kuhn merged patch set 9 11/27/21, 22:59